scala3 icon indicating copy to clipboard operation
scala3 copied to clipboard

Add binary lits to syntax summaries

Open som-snytt opened this issue 1 year ago • 9 comments

Some redundancy was omitted at https://github.com/lampepfl/dotty/pull/19405

https://dotty.epfl.ch/docs/reference/syntax.html

som-snytt avatar Jan 27 '24 22:01 som-snytt

Sorry I forgot how to turn off CI over here.

som-snytt avatar Jan 27 '24 22:01 som-snytt

One question: The tooling people said they want to be notifed of any changes to syntax before the syntax is rolled in. Did that happen? @tgodzik @gabro are you aware that this change has landed?

odersky avatar Jan 28 '24 12:01 odersky

One question: The tooling people said they want to be notifed of any changes to syntax before the syntax is rolled in. Did that happen? @tgodzik @gabro are you aware that this change has landed?

Hmm... I don't think it did happen. We will need to take a look into it.

tgodzik avatar Jan 28 '24 19:01 tgodzik

@tgodzik @gabro Are you OK with merging this now, and you'll look into the tooling separately? Or should we hold?

odersky avatar Feb 01 '24 12:02 odersky

@tgodzik @gabro Are you OK with merging this now, and you'll look into the tooling separately? Or should we hold?

I will not be able to take a look at it soon, so I would opt to hold off for a bit. I will try to find time on the weekend to take a look at it, but I can't promise anything.

tgodzik avatar Feb 01 '24 14:02 tgodzik

@tgodzik heads up it was also already merged in scala 2.13

bishabosha avatar Feb 01 '24 15:02 bishabosha

Och, that ship has sailed then :fearful: I will try to get some time to work on it.

tgodzik avatar Feb 01 '24 18:02 tgodzik

It will land in 3.5.

odersky avatar Feb 15 '24 16:02 odersky

We added support in the latest version of Scalameta 3.9.0 https://github.com/scalameta/scalameta/pull/3543

tgodzik avatar Feb 15 '24 16:02 tgodzik