scala3 icon indicating copy to clipboard operation
scala3 copied to clipboard

Published 20 hours ago • verified publisher icon scala

Add support for JEP-409 (sealed classes) + Add javacOpt directive

Open hamzaremmal opened this issue 1 year ago • 6 comments

Closes #18533

This PR also adds the following directive to the vulpix infrastructure:

//> using javacOpt *

inspired by : https://scala-cli.virtuslab.org/docs/reference/directives#javac-options

hamzaremmal avatar Nov 25 '23 22:11 hamzaremmal

The scala 2 ticket links to the two PRs which may be helpful. The tricky part was that if permitted subclasses is not specified, you have to discover them in the source, but without requiring too much typechecking.

https://github.com/scala/bug/issues/12171

som-snytt avatar Nov 25 '23 22:11 som-snytt

Is this fix blocked by anything?

unkarjedy avatar Feb 14 '24 15:02 unkarjedy

No

hamzaremmal avatar Feb 14 '24 15:02 hamzaremmal

CI needs (at least) Java 21 to pass. Waiting for #18873.

hamzaremmal avatar Feb 14 '24 20:02 hamzaremmal

There is a current syntax that is not yet migrated to cli-style just for avoiding old jvm.

./tests/run/t12348.scala:// test: -jvm 11+

som-snytt avatar Feb 15 '24 01:02 som-snytt

There is a current syntax that is not yet migrated to cli-style just for avoiding old jvm.


./tests/run/t12348.scala:// test: -jvm 11+

I'm familiar with this directive. I want to run the test at least once in the CI with the correct JVM before adding this directive.

hamzaremmal avatar Feb 15 '24 09:02 hamzaremmal