scala-steward icon indicating copy to clipboard operation
scala-steward copied to clipboard

GitHub actions workflow `.yml` file not updated

Open mkurz opened this issue 3 years ago • 1 comments

See https://github.com/playframework/play-json/pull/759 Shouldn't also the Scala version be updated in a GHA workflow file? At the time the pull request got opened by scala-steward the exact same version (3.1.3-RC2) could be found in https://github.com/playframework/play-json/blob/9bd7d5ec6b6f3f42eeb63fbedd3efa7ac30005e5/.github/workflows/build-test.yml#L41. However, scala steward did not update the version in that file...

According to the default configs

  • https://github.com/scala-steward-org/scala-steward/blob/0a4d1a09b47760b51c89870db3ba25430aae8ad2/docs/repo-specific-configuration.md?plain=1#L61 and
  • https://github.com/scala-steward-org/scala-steward/blob/d43fad147af294abd64f745cc6120e4993075ae1/modules/core/src/main/scala/org/scalasteward/core/repoconfig/UpdatesConfig.scala#L76-L77

shouldn't those yml files be updated as well?

mkurz avatar May 19 '22 11:05 mkurz

I’ve tried to reproduce in https://github.com/scala-steward-org/scala-steward/pull/2780 but GitHub action file was updated in the test case at least 🤔

exoego avatar Nov 18 '22 08:11 exoego