scala-steward icon indicating copy to clipboard operation
scala-steward copied to clipboard

Support for setting required number of reviewers on GitLab merge requests

Open dkichler opened this issue 3 years ago • 2 comments

This feature would be useful for helping automate merging ScalaSteward MRs in the context where most other MRs are subject to minimum reviewer rules.

This would be mostly to support running ScalaSteward over private repositories where credentials provided through runtime parameters would require the sufficient privileges for this operation through the GitLab API.

dkichler avatar Feb 09 '22 19:02 dkichler

A bit more rationale for this feature request:

  • Ideally this would be achievable through more dynamic MR approval rules in GitLab. This is on their roadmap, but until then this feature would greatly help automate our ScalaSteward process.
  • Trying to keep our solution open source and the free tier of Mergify does not support the features we would need to replicate this solution.

dkichler avatar Feb 14 '22 14:02 dkichler

This is on their roadmap, but until then this feature would greatly help automate our ScalaSteward process.

Could you share the link to the roadmap? After GitLab released it, we may remove this feature.

exoego avatar May 20 '22 03:05 exoego

Could you share the link to the roadmap? After GitLab released it, we may remove this feature.

The feature request I was watching is this one: https://gitlab.com/gitlab-org/gitlab/-/issues/282495

It looks like they've already backed away from it (not uncommon)

dkichler avatar Nov 22 '22 14:11 dkichler