scala-steward icon indicating copy to clipboard operation
scala-steward copied to clipboard

False matching in yaml file.

Open ckipp01 opened this issue 3 years ago • 0 comments

At work I noticed today a bunch of updates were sent in that ended up breaking builds due to an incorrect matching in a yaml file. The example that it happened in can be minimized to:

lazy val library = new {
  object version {
    val dep = "1.3.0"
  }

  val fullDep = "org" %% "name" % version.dep
}

A pr was sent in to update this dep from 1.3.0 -> 1.3.1 which was correct. However at the root of our repo we also have a build.yml file which is used in CI to set up our env. In that build.yml there was the following:

image: our-registry/name:tagname-v1.3.0-1

Steward also tried changing this.

- image: our-registry/name:tagname-v1.3.0-1
+ image: our-registry/name:tagname-v1.3.1-1

I'd expect this not to update the yaml file especially since the version imo doesn't match. 1.3.0 should be matched with 1.3.0-1.

ckipp01 avatar Dec 17 '21 10:12 ckipp01