scala-steward icon indicating copy to clipboard operation
scala-steward copied to clipboard

Updating random values in the codebase that match the updated version.

Open ckipp01 opened this issue 4 years ago • 0 comments

The repo that this happened in is private, but I'll do my best to outline what happened below. If there is anything else you need to better identify what may have happened, let me know.

lazy val library = new Object {
  object Version {
        val akkaAlpakka                = "3.0.0"
   }

  val akkaAlpakkaS3          = "com.lightbend.akka"     %% "akka-stream-alpakka-s3"    % version.akkaAlpakka
  val akkaStreamAlpakkaFile  = "com.lightbend.akka"     %% "akka-stream-alpakka-file"  % version.akkaAlpakka
}

The pr sent in changed this 3.0.0 to 3.0.1 correctly in the build.sbt, but it included a warning that it wasn't updated in a few places:

The following files still refer to the old version number (3.0.0).
You might want to review and update them manually.
package-lock.json
scalableTest-compose/package-lock.json
server/src/main/resources/<redacted>/<redacted>_OD_v3.0.0_<redacted>-1.0.2.xml
server/src/test/scala/<redacted>/repositories/<redacted>Spec.scala

That was fine, however there were a couple places in the codebase that 3.0.0 was updated to 3.1.1.

  lazy val `Module Object Recognition v3.0`: OurType =
-    load(resourceName = "<redacted>/<redacted>_OD_v3.0.0_<redacted>-1.0.2.xml")
+    load(resourceName = "<redacted>/<redacted>_OD_v3.0.1_<redacted>-1.0.2.xml")

Another was in a spec file:

 "some test name" in { f =>
      for {
        _ <- f.<redacted>.persist(
          Seq(
            ...
-            f.stuff.copy(<redacted>Version    = "3.0.0")
+            f.stuff.copy(<redacted>Version    = "3.0.1")
          )
        )
...

I'm assuming this has to do with the first one being a lazy val maybe and the second included Version =?

ckipp01 avatar Jun 08 '21 06:06 ckipp01