scala-js-dom icon indicating copy to clipboard operation
scala-js-dom copied to clipboard

Published 20 hours ago • verified publisher icon scala-js

Add upgrade() whenDefined() to CustomElementRegistry

Open cyz1901 opened this issue 1 year ago • 4 comments

Hi there!

Before submitting a PR containing any Scala changes, please make sure you...

  • run sbt prePR
  • commit changes to api-reports

Thanks for contributing!

add upgrade() whenDefined() to CustomElementRegistry

cyz1901 avatar Jan 14 '24 08:01 cyz1901

Hello team. I am not sure should we also add the get() and getName() functions, which seems to involve the type being a constructor...

cyz1901 avatar Jan 14 '24 08:01 cyz1901

Hmm. I think the type for a constructor should be js.Dynamic. For example see val constructor in this API: https://www.scala-js.org/api/scalajs-library/latest/scala/scalajs/js/ConstructorTag.html

armanbilge avatar Jan 14 '24 08:01 armanbilge

Hmm. I think the type for a constructor should be js.Dynamic. For example see val constructor in this API: https://www.scala-js.org/api/scalajs-library/latest/scala/scalajs/js/ConstructorTag.html

Added

cyz1901 avatar Jan 14 '24 12:01 cyz1901

fixed

cyz1901 avatar Mar 06 '24 16:03 cyz1901