scaffold-eth-2 icon indicating copy to clipboard operation
scaffold-eth-2 copied to clipboard

Cli solidity framework option

Open rin-st opened this issue 3 months ago • 1 comments

Description

Solidity framework option from CLI. It could be a discussion but I think in this case it's easier to discuss when you already see the code. Feel free to add suggestions 🙂

usage examples (dev):

yarn cli --solidity-framework hardhat
yarn cli --solidity-framework=foundry
yarn cli -f none

In case of several solidity framework flags, last will be taken

Other options I thought about.

  1. --hardhat, --foundry and --skip-solidity-framework. Looks bad. Need to check if two or more flags chosen and add additional ifs to fix/throw error
  2. --extensions flag. It's not clear how to add let's say none, and how to mix it with other extensions non-related to solidity frameworks

Not sure how it will work with nested extensions but I think it's not a problem to update recurring logic if needed.

Also in this pr I added error if both --install and --skip-install chosen

Thanks!

Additional Information

  • [x] I have read the contributing docs (if this is your first contribution)
  • [x] This is not a duplicate of any existing pull request

rin-st avatar Apr 05 '24 19:04 rin-st