scaffold-eth-2
scaffold-eth-2 copied to clipboard
Cli solidity framework option
Description
Solidity framework option from CLI. It could be a discussion but I think in this case it's easier to discuss when you already see the code. Feel free to add suggestions 🙂
usage examples (dev):
yarn cli --solidity-framework hardhat
yarn cli --solidity-framework=foundry
yarn cli -f none
In case of several solidity framework flags, last will be taken
Other options I thought about.
-
--hardhat
,--foundry
and--skip-solidity-framework
. Looks bad. Need to check if two or more flags chosen and add additionalif
s to fix/throw error -
--extensions
flag. It's not clear how to add let's saynone
, and how to mix it with other extensions non-related to solidity frameworks
Not sure how it will work with nested extensions but I think it's not a problem to update recurring logic if needed.
Also in this pr I added error if both --install
and --skip-install
chosen
Thanks!
Additional Information
- [x] I have read the contributing docs (if this is your first contribution)
- [x] This is not a duplicate of any existing pull request
I like it!
I think it's good to be able to set the solidity framework to use directly from the command line.
@rin-st could you please port this PR to create-eth repo? This is will also open the doors for https://github.com/scaffold-eth/create-eth/issues/23
closing due to https://github.com/scaffold-eth/create-eth/pull/58