scaffold-eth-2 icon indicating copy to clipboard operation
scaffold-eth-2 copied to clipboard

gh-actions fails for foundry

Open Hotmanics opened this issue 7 months ago • 12 comments

Is there an existing issue for this?

Current Behavior

When using a project built with "npx create-eth@latest" and the selected option for "What solidity framework do you want to use" is "Foundry", then any time successfully push commit to GitHub, the Git Hooks will fail on the step "Run hardhat node, deploy contracts (& generate contracts typescript output)".

Expected Behavior

When pushing a commit to GitHub while using a project built from "npx create-eth@latest" and Foundry is the selected Solidity Framework, then the Git Hooks should succeed in deploying a local foundry chain and deploy contracts (& generate contracts typescript output).

Steps To Reproduce

  1. Go to: https://scaffoldeth.io/.
  2. Open CLI.
  3. Run command "npx create-eth@latest" from "https://scaffoldeth.io" in CLI.
  4. In CLI, enter any project name.
  5. In CLI, Select "Foundry" as the selected Solidity Framework.
  6. In CLI, Select "yes" to Install packages.
  7. Wait for packages to install, and observe the created project files on your local machine.
  8. Clone an empty repository from Github to local machine.
  9. Move the created project files from local machine into the local empty repository.
  10. Observe changes, commit changes, push changes.
  11. Wait for Git hooks to be ran on Github.com. Should fail.

Anything else?

You can see my current implementation in my own project here: https://github.com/ATXDAO/reputation-and-roles-monorepo/actions/runs/6869607334/job/18682721792

Hotmanics avatar Nov 14 '23 22:11 Hotmanics