Scaffold-ETH-DeFi-Challenges
Scaffold-ETH-DeFi-Challenges copied to clipboard
Fix gh actions to use foundry
Description :
These new changes will :
- Run foundry chain
- Runs
yarn deploy
- Does the linting and types check for only frontend.
TODO:
- [ ] Add
ETHERSCAN_API_KEY
in Github secrets I think we can use API key which comes with SE-2
I think I don't have the permission to add GH secrets, @steve0xp or @MattPereira could you please add it 🙌
Fixes #23
Hey @technophile-04,
I'm about to start working on my first PR for issue 607, and this looks like most of the fixes I had locally.
Want me to create a new PR that will focus on having the cli branch have the contracts linting stage split out to the hardhat and foundry branches?
Whoa, sorry I just saw these comments now. Holiday season was a bit all over the place with work too. Okay, @MattPereira or I will take a look at this hopefully by the end of this coming weekend.
Description :
These new changes will :
- Run foundry chain
- Runs
yarn deploy
- Does the linting and types check for only frontend.
TODO:
- [ ] Add
ETHERSCAN_API_KEY
in Github secrets I think we can use API key which comes with SE-2I think I don't have the permission to add GH secrets, @steve0xp or @MattPereira could you please add it 🙌
Fixes #23
Hampton-Black
@Hampton-Black, Shiv is a great person to contact to help out w/ BUIDL GUIDL and everything. If you want to work on stuff regarding this repo lmk of course too.
Whoa, sorry I just saw these comments now. Holiday season was a bit all over the place with work too. Okay, @MattPereira or I will take a look at this hopefully by the end of this coming weekend.
No hurry! Tysm 🙌
@Hampton-Black Want me to create a new PR that will focus on having the cli branch have the contracts linting stage split out to the hardhat and foundry branches?
Yup already added a comment at OP https://github.com/scaffold-eth/scaffold-eth-2/issues/607#issuecomment-1868214478, please feel free add a comment on that issue always happy to help!