Scaffold-ETH-DeFi-Challenges icon indicating copy to clipboard operation
Scaffold-ETH-DeFi-Challenges copied to clipboard

Fix gh actions to use foundry

Open technophile-04 opened this issue 1 year ago • 4 comments

Description :

These new changes will :

  1. Run foundry chain
  2. Runs yarn deploy
  3. Does the linting and types check for only frontend.

TODO:

  • [ ] Add ETHERSCAN_API_KEY in Github secrets I think we can use API key which comes with SE-2

I think I don't have the permission to add GH secrets, @steve0xp or @MattPereira could you please add it 🙌

Fixes #23

technophile-04 avatar Dec 18 '23 08:12 technophile-04

Hey @technophile-04,

I'm about to start working on my first PR for issue 607, and this looks like most of the fixes I had locally.

Want me to create a new PR that will focus on having the cli branch have the contracts linting stage split out to the hardhat and foundry branches?

Hampton-Black avatar Dec 22 '23 19:12 Hampton-Black

Whoa, sorry I just saw these comments now. Holiday season was a bit all over the place with work too. Okay, @MattPereira or I will take a look at this hopefully by the end of this coming weekend.

Description :

These new changes will :

  1. Run foundry chain
  2. Runs yarn deploy
  3. Does the linting and types check for only frontend.

TODO:

  • [ ] Add ETHERSCAN_API_KEY in Github secrets I think we can use API key which comes with SE-2

I think I don't have the permission to add GH secrets, @steve0xp or @MattPereira could you please add it 🙌

Fixes #23

steve0xp avatar Jan 04 '24 03:01 steve0xp

Hampton-Black

@Hampton-Black, Shiv is a great person to contact to help out w/ BUIDL GUIDL and everything. If you want to work on stuff regarding this repo lmk of course too.

steve0xp avatar Jan 04 '24 03:01 steve0xp

Whoa, sorry I just saw these comments now. Holiday season was a bit all over the place with work too. Okay, @MattPereira or I will take a look at this hopefully by the end of this coming weekend.

No hurry! Tysm 🙌

@Hampton-Black Want me to create a new PR that will focus on having the cli branch have the contracts linting stage split out to the hardhat and foundry branches?

Yup already added a comment at OP https://github.com/scaffold-eth/scaffold-eth-2/issues/607#issuecomment-1868214478, please feel free add a comment on that issue always happy to help!

technophile-04 avatar Jan 04 '24 22:01 technophile-04