Scala Buggabot
Scala Buggabot
mathieu leclaire (mamat) said (edited on Mar 15, 2012 3:59:25 PM UTC): Hi, I wrote a patch for the ComboBox class taking into account the java parametrized classes. It enables...
Imported From: https://issues.scala-lang.org/browse/SI-1613?orig=1 Reporter: Daniel Willmann (dwillmann)
Thomas Santana (mailleux) said: I achieved this using a combo box which you can specify the model. Here is the example: https://github.com/nebulorum/virtual-combat-cards/blob/master/vcc-swing/src/main/scala/vcc/util/swing/ExplicitModelComboBox.scala I would recommend making ComboBox accept a mode....
Imported From: https://issues.scala-lang.org/browse/SI-8495?orig=1 Reporter: Christoph Langguth (clangguth) Affected Versions: 2.10.3 Attachments: - [PublisherBugTest.scala](https://issues.scala-lang.org/secure/attachment/15914/PublisherBugTest.scala) (created on Apr 11, 2014 2:09:44 PM UTC, 2342 bytes) - [PublisherTest.scala](https://issues.scala-lang.org/secure/attachment/15920/PublisherTest.scala) (created on Apr 28, 2014...
@andy1138 said: PR for review: https://github.com/scala/scala-swing/pull/6
Christoph Langguth (clangguth) said: Thanks Andy! Looks good so far, just two small comments: 1. I'm not sure if the test description is entirely correct. Right now it's "listeners should...
Christoph Langguth (clangguth) said (edited on Apr 28, 2014 2:45:38 PM UTC): Ok, so [here](https://issues.scala-lang.org/secure/attachment/15920/PublisherTest.scala) is the attachment I mentioned above. It's a minimally modified version of https://github.com/andy1138/scala-swing/commit/bc8005348afff268132f5fd279d04948744a4523 (changed test...
@andy1138 said: Hi Christoph I've updated the code with your test, much better, thanks On containsItem, I think that if the item has been removed from 'listeners' then it should...
Christoph Langguth (clangguth) said: Hi Andy, thanks again for the quick reaction! I think the test now covers all cases that could possibly go wrong :-) Concerning the logic (and...
@andy1138 said: Hi Chris I've been distracted by work, and the 2nd part of this, but continuing on ... Interesting, I think of it the other way around. as a...