Deprecate GenericMappers.mapMiniSetup

[stuhood]

The protobuf analysis format does not apply the mapMiniSetup method, but actually does something a bit better: it applies mapOutputDir to the output dir, and the relevant other mapping methods (mapSourceFile, mapBinaryFile, etc) to the relevant fields of the MiniSetup.

It should thus be possible to deprecate mapMiniSetup (or at least give it a default noop implementation).

[stuhood]

Hm, so: it looks like maybe mapMiniSetup is only applied in TextAnalysisFormat.

But the protobuf analysis format actually does something a bit better: it applies mapOutputDir to the output dir. If it were to also apply mapSourceFile, mapBinaryFile, etc to all of the relevant fields of the MiniSetup, I think that we could deprecate the mapMiniSetup method.

Thoughts @jvican ?

[stuhood]

I was totally wrong about MiniSetup not being portable. Have updated the title/description.

[jvican]

But the protobuf analysis format actually does something a bit better: it applies mapOutputDir to the output dir. If it were to also apply mapSourceFile, mapBinaryFile, etc to all of the relevant fields of the MiniSetup, I think that we could deprecate the mapMiniSetup method.

It makes sense to deprecate mapMiniSetup and implement your suggestion of mapping everything in it mapSourceFile, mapBinaryFile, etc. :+1: