zinc icon indicating copy to clipboard operation
zinc copied to clipboard

Update scala-compiler to 2.13.18

Open scala-steward opened this issue 3 months ago • 2 comments

About this PR

📦 Updates org.scala-lang:scala-compiler from 2.13.16 to 2.13.18

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (2.13.16). You might want to review and update them manually.

internal/zinc-core/src/main/scala/sbt/internal/inc/RootPath.scala
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-compiler" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-compiler" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

scala-steward avatar Nov 26 '25 22:11 scala-steward

How can the failing tests be fixed?

$ grep -r --exclude-dir=.git --exclude-dir=target '2\.13\.1'
internal/zinc-benchmarks/src/test/scala/xsbt/ZincBenchmark.scala:  val scalaVersion = "2.13.18"
internal/compiler-bridge-test/src/test/scala/sbt/internal/inc/CompilingSpecification.scala:  def scala213 = "2.13.18"
project/Dependencies.scala:  val scala213 = "2.13.18"
project/Dependencies.scala:  val scala213ForBridge = "2.13.18"

I can not see were 2.13.16 can be bumped. I guess some external dep needs to be updated? Or sbt itsel needs to bump to 2.13.18 before?

mkurz avatar Dec 01 '25 13:12 mkurz

How can the failing tests be fixed?

I think in theory the diff should have worked? Bumping to 2.13.16 was automatic - https://github.com/sbt/zinc/pull/1530. Also given that Scala 2.13 has in-sourced the bridge implementation, I'm also not sure if we should bump the 2.13 version used to test our bridge implementation.

eed3si9n avatar Dec 11 '25 06:12 eed3si9n