sbt-native-packager icon indicating copy to clipboard operation
sbt-native-packager copied to clipboard

Fixes for argument handling in AshScriptPlugin's script template

Open kevinmehall opened this issue 2 years ago • 4 comments

  • Previously the -main argument was ignored because the custom_mainclass variable was set but never used. process_args is called after app_mainclass is set to the default value, so this PR makes it simply overwrite app_mainclass instead of introducing another variable.
  • Previously the additional arguments passed on the command line were passed to java before the defaults, which means the defaults take precedence and couldn't be overridden. This puts the flags from JAVA_OPTS and the command line after the defaults, which matches the behavior of the Bash template.

kevinmehall avatar Aug 25 '21 21:08 kevinmehall

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Aug 25 '21 21:08 lightbend-cla-validator

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Aug 28 '21 11:08 lightbend-cla-validator

Can you sign the Contributor CLA?

muuki88 avatar Aug 28 '21 11:08 muuki88

Hi @kevinmehall,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Sep 02 '21 13:09 lightbend-cla-validator