sbt-native-packager
sbt-native-packager copied to clipboard
Fixes for argument handling in AshScriptPlugin's script template
- Previously the
-mainargument was ignored because thecustom_mainclassvariable was set but never used.process_argsis called afterapp_mainclassis set to the default value, so this PR makes it simply overwriteapp_mainclassinstead of introducing another variable. - Previously the additional arguments passed on the command line were passed to
javabefore the defaults, which means the defaults take precedence and couldn't be overridden. This puts the flags fromJAVA_OPTSand the command line after the defaults, which matches the behavior of the Bash template.
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
Can you sign the Contributor CLA?
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: