sbt-native-packager
sbt-native-packager copied to clipboard
Fixes for argument handling in AshScriptPlugin's script template
- Previously the
-main
argument was ignored because thecustom_mainclass
variable was set but never used.process_args
is called afterapp_mainclass
is set to the default value, so this PR makes it simply overwriteapp_mainclass
instead of introducing another variable. - Previously the additional arguments passed on the command line were passed to
java
before the defaults, which means the defaults take precedence and couldn't be overridden. This puts the flags fromJAVA_OPTS
and the command line after the defaults, which matches the behavior of the Bash template.
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
Can you sign the Contributor CLA?
Hi @kevinmehall,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: