sbt-native-packager icon indicating copy to clipboard operation
sbt-native-packager copied to clipboard

Published 20 hours ago • verified publisher icon sbt

Fix dockerPackageMappings to be absolute paths

Open joan38 opened this issue 4 years ago • 5 comments

Fixes https://github.com/sbt/sbt-native-packager/issues/1304

joan38 avatar Feb 05 '20 21:02 joan38

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

lightbend-cla-validator avatar Feb 05 '20 21:02 lightbend-cla-validator

I don't think MappingsHelper has any issue since it returns relative paths by design.

Your concerne about the underlying OS would be an issue if we are using a different OS in the docker image we are building (not the host machine that is running SBT).

I will add a test for it.

joan38 avatar Feb 11 '20 20:02 joan38

Hi @joan38 thanks again for tackeling this :smiley: Do you know if you have the time to add some tests for this?

muuki88 avatar Oct 21 '20 08:10 muuki88

Hi @muuki88, I'm not sure I'll have much time to do this also since we moved away from SBT to Mill.

joan38 avatar Oct 23 '20 18:10 joan38

Thanks for the update @joan38 😊

muuki88 avatar Oct 23 '20 19:10 muuki88