sbt-native-packager
sbt-native-packager copied to clipboard
sbt
Issue 1264 bugfix refactor
Hello
Added AshStartScriptPlugin with associated keys, templates, tests. Made it so it does not depend on BashStartScriptPlugin keys and defines. It has to be explicitly enabled with enablePlugins.
The generated scripts do not have quite the same usage as bash/bat scripts. Maybe someone can realign them later and add to docs.
Hi @archeuclid,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla
Hello Ok
This project need lots of refactor. The scripts must be part of "staging", since it is so close related to JavaAppPackaging. I suggest to write specs for scripts then incorporate them in the "stage".
Also, suggest changing the name from "stage" ("Stager" etc). It is a DevOps term and must be delineated from SoftwareDevs.
Sorry, guys. Lots of stuff to work on hand right now. Use the template .sh in any way you want. I will delete this pull request next time I am here or reject it.
Cheers
@briantopping unfortunately not. We have no releases for pull requests. You will need to checkout this pull request and build on your own :( Or you finish this PR and we release :)
No worries, I converted the code that depends on this to pass arguments as environment variables. My shell skills are poor at best.
My shell skills are poor at best
You are in good company @briantopping Since kubernetes we have to fight more with YAML than anything else :joy: