sbt-native-packager icon indicating copy to clipboard operation
sbt-native-packager copied to clipboard

JDKPackager for windows does not show the appropriate information for MSI creation if two versions exist in the bundles folder

Open markehammons opened this issue 6 years ago • 3 comments

Expected behaviour

For an application named artifact with version 1.0.1 with a previously generated msi for version 1.0.0 in the bundles folder: When I finish producing the MSI, I expect the MSI produced to be reported correctly at the end with the text "Wrote ...\universal\jdkpackager\bundles\artifact-1.0.1.msi"

Actual behaviour

The text is "Wrote ...\universal\jdkpackager\bundles\artifact-1.0.0.msi"

Information

  • sbt-native-packager 1.3.3
  • 1.1.0
  • Windows 10
  • MSI
  • wix 311
  • Windows

markehammons avatar Feb 23 '18 15:02 markehammons

Thanks for your report 😀. Could you add some additional information:

  • a minimal build.sbt to reproduce this
  • the steps you perform to trigger this behaviour

muuki88 avatar Feb 24 '18 12:02 muuki88

Triggering it is pretty easy. Set version to something like 1.0.0 and package the build with the jdkPackager. Then set the build to version 1.0.1 and do the same. The packager will report that 1.0.0 has been created. It's a cosmetic flaw, but confusing. As for a minimal build.sbt, I'll work on that soon.

markehammons avatar Mar 18 '18 23:03 markehammons

How do you change the version? Do you do it the sbt console with set version := "1.0.1" or is the build.sbt change (e.g. with sbt-release?).

muuki88 avatar Apr 02 '18 17:04 muuki88