sbt-java-formatter icon indicating copy to clipboard operation
sbt-java-formatter copied to clipboard
verified publisher icon sbt

Upgrade google formatter to v1.26.0 - Requires Java 17

Open mkurz opened this issue 10 months ago • 5 comments

mkurz avatar Apr 10 '25 11:04 mkurz

Matthias, do you want to merge this before next release?

ihostage avatar Apr 10 '25 12:04 ihostage

I want to merge this an publish is as v1.0.0

mkurz avatar Apr 10 '25 12:04 mkurz

So 0.9 is for Java 8, 0.10 is for Java 11 and 1.x is for Java 17+

mkurz avatar Apr 10 '25 12:04 mkurz

Nooo.... --add-exports is needed now...

  • https://github.com/google/google-java-format?tab=readme-ov-file#intellij-jre-config
  • https://github.com/search?q=repo%3Agoogle%2Fgoogle-java-format%20--add-exports&type=code
  • https://github.com/google/google-java-format/issues/787

For the scripted tests we can add them do the scriptedLaunchOpts I guess. Will do that later, need to head out for an appointment

mkurz avatar Apr 10 '25 12:04 mkurz

@mkurz Please, don't release 1.0.0 yet 🙏

ihostage avatar Apr 10 '25 13:04 ihostage