sbt-assembly icon indicating copy to clipboard operation
sbt-assembly copied to clipboard

scala-xml no longer part of core library in Scala-3...

Open DavidGoodenough opened this issue 2 years ago • 2 comments

but it is excluded by the includeScala=false directive as its file name starts with "scala-".

Unfortunately once excluded there appears to be no way to override the exclusion. So the logic that decided which .jar files to include when this option is used needs to be updated to use a better way of determining whether to include .jar content.

DavidGoodenough avatar Jun 05 '22 15:06 DavidGoodenough

Hello, we've come across the same issue specifically for scala-xml. It appears the below check is flawed.

We're on Scala 3.3.1, so we would pass the >=2 check put fail the >=13 for the minor version.

https://github.com/sbt/sbt-assembly/blob/56f7e715ac3444237c8f1fd6c88abceeaf641e4a/src/main/scala/sbtassembly/Assembly.scala#L244-L249

As more users take on Scala 3.3 this will likely become more of an issue.

TimBloy avatar Apr 02 '24 11:04 TimBloy

As @TimBloy mentions the logic seems to predate Scala 3. The Scala 3 artifacts have even different names ("scala3-compiler" and "scala3-library")

mzuehlke avatar Apr 02 '24 14:04 mzuehlke