docker-sbt icon indicating copy to clipboard operation
docker-sbt copied to clipboard

Add amazon-corretto base image (17, 11)

Open kijuky opened this issue 2 years ago • 9 comments

  • copy eclipse-temurin dockerfile
  • change apt-get -> yum (for amazon linux)
    • The base image doesn't even have tar or gzip so I'm running that first.

kijuky avatar Jul 31 '22 08:07 kijuky

I wonder at what point github will tell us we have too many builds

Are you actively using jdk 8? Maybe this belongs in a fork?

francisdb avatar Aug 01 '22 07:08 francisdb

Are you actively using jdk 8?

surely.... 8 is erased.

kijuky avatar Aug 01 '22 12:08 kijuky

I wonder at what point github will tell us we have too many builds

In many cases, having an LTS is enough. So just 11 and 17. If you ever need 18, make another pull request at that time.

kijuky avatar Aug 01 '22 12:08 kijuky

Looks like the scala 3 docker build is failing on something related to tput in the scala startup script:

https://github.com/lampepfl/dotty/blob/1130c52a6476d473b41a598e23f0415e0f8d76dc/dist/bin/common#L31-L34

introduced in https://github.com/lampepfl/dotty/pull/10304

Also found this related thread https://github.com/edeliver/edeliver/issues/188#issuecomment-475833389

Might be something to report on the dotty issue tracker

francisdb avatar Aug 01 '22 15:08 francisdb

see https://github.com/lampepfl/dotty/issues/15796

francisdb avatar Aug 01 '22 15:08 francisdb

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

francisdb avatar Aug 01 '22 15:08 francisdb

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

I will try it!

kijuky avatar Aug 01 '22 22:08 kijuky

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

I tried adding this option, but it didn't help. Even if I change the settings or environment variables, tput will always be executed. As a last resort, I renamed tput only when running scala.

Doesn't seem like a very good way to do it, but I was out of ideas... 😢

kijuky avatar Aug 06 '22 08:08 kijuky