docker-sbt icon indicating copy to clipboard operation
docker-sbt copied to clipboard

Switch to eclipse-temurin by default?

Open francisdb opened this issue 2 years ago • 3 comments

These come with ubuntu/alpine/windowsservercore

This is mentioned on the openjdk docker page


https://hub.docker.com/_/openjdk?tab=description

WARNING

If you are a user/consumer of Java, this image is probably not what you expect!

These images contain "vanilla" builds of the OpenJDK project provided by Oracle or the relevant "updates project lead" (depending on the version).

For a more "supported" experience, we recommend one of the following other Official Images (listed in alphabetical order with no intentional or implied preference):

[amazoncorretto](https://hub.docker.com/_/amazoncorretto)
[eclipse-temurin](https://hub.docker.com/_/eclipse-temurin)
[ibm-semeru-runtimes](https://hub.docker.com/_/ibm-semeru-runtimes)
[ibmjava](https://hub.docker.com/_/ibmjava)
[sapmachine](https://hub.docker.com/_/sapmachine)

francisdb avatar May 31 '22 08:05 francisdb

+1 on Eclipse Temurin. I explicitly endorse that on https://www.scala-sbt.org/1.x/docs/Installing-sbt-on-Linux.html page as well over distro JDKs.

eed3si9n avatar May 31 '22 14:05 eed3si9n

The question is a bit what is "by default" We probably can't just switch as the openjdk images without qualifier are based on debian and temurin is based on ubuntu? Maybe it's enough to:

  • repeat above concern in the readme
  • update all examples to use temurin
  • stop updating openjdk images, remove them from the build

francisdb avatar Jun 28 '22 15:06 francisdb

Now that this image is under new management/sbtscala, I think there's some degree of design freedom we earned under the new name. I personally see Ubuntu and Debian both as distribution of deb-based distro.

eed3si9n avatar Jun 28 '22 15:06 eed3si9n

Readme was update in 4d959120f79c14fecc87407032cf9bb26c2e148a Will for now namespace the openjdk images as openjdk-* so that users don't think these are the default images.

francisdb avatar Sep 22 '22 12:09 francisdb

Going to close this for now, we clearly promote eclipse-temurin on the README / at https://hub.docker.com/r/sbtscala/scala-sbt

francisdb avatar Sep 22 '22 14:09 francisdb