Bug: no zsh_history in sub shell

[codejnki]

When I start a new kubie ctx session it has no history. This appears to be similar to #31.

Looking a PR #32 and comparing it to the current state of https://github.com/EItanya/kubie/blob/master/src/shell/zsh.rs it appears that the fix may no longer be in the current release.

Can the commit from #32 get merged into master and a new release cut?

[ghostsquad]

yes please! I really need this. I've found myself not wanting to be in a kubie shell because my history doesn't get saved. :(

[simonst]

It would be really helpful to have this in again!

[rvignesh89]

I had the same issue and it turns out history is indeed copied over to the sub-shells if the .zsh_history is correctly populated - https://github.com/sbstp/kubie/blob/master/src/shell/zsh.rs#L40-L43

It turns out you can set the location of the history file by setting the HISTFILE var (https://ryantoddgarza.com/a-better-zsh-history-pt1) Somehow this was configured incorrectly in my shell and overriding that to ~/.zsh_history did the trick for me. Not sure if it's the same issue for others in this thread though.

[megumish]

thanks @rvignesh89 . I set up the HISTFILE and it works!

However, I still think #32 should be merged into the release for those who want to run without this configuration.

[codejnki]

I was able to pull master and build it locally and now history is present. So that could be an option for some people.

I do think we could benefit from a fresh release being cut and pushed out to the package managers.

[sbstp]

I'll create a new release

[CharlesB2]

This was driving me nuts until I found that it was kubie causing to lose history