sqs-worker-serverless icon indicating copy to clipboard operation
sqs-worker-serverless copied to clipboard

Scale up Cloudwatch Alarm Regex typo

Open lucasklaassen opened this issue 7 years ago • 3 comments

Hey man, thanks for putting this together! I love how it works.

Just noticed when I tried to port this to my project that the scale up Cloudwatch alarm regex has a typo: https://github.com/sbstjn/sqs-worker-serverless/blob/master/functions/scale.js#L7

The Cloudwatch alarms that were set up for me had Message being singular instead of plural.

Maybe I misconfigured something but I believe we should update:

 const regex = /(OK|ALARM):(.*)MessagesAlarm([0-9]*)/g

to

 const regex = /(OK|ALARM):(.*)MessageAlarm([0-9]*)/g

lucasklaassen avatar Jul 23 '17 01:07 lucasklaassen

the test has to be updated as well. many many thanks for this example.

oanabotezat avatar Nov 28 '17 11:11 oanabotezat

@oanabotezat Added PR with test updates, thanks for the comment!

lucasklaassen avatar Nov 30 '17 00:11 lucasklaassen

@sbstjn any issues with PR on this one?

lucasklaassen avatar Mar 08 '18 16:03 lucasklaassen