Steven Brus

Results 32 comments of Steven Brus

@mark-petersen, I believe I have fixed the issues with `SMS_D_Ln3.CFSR_wQU225EC60to30.VWW3-CFSR` and `SMS_D_Ln3.CFSv2_wQU225EC60to30.VWW3-CFSv2`. One issue I ran across is that it appears that the datm encounters an out of bounds error...

Also, for the short term achieve step to pass, the lines: https://github.com/ESMCI/cime/blob/98106c908bd3b5514239e56efdc7ab6a53524065/CIME/case/case_st_archive.py#L1187-L1188 need to be removed. This would require a cime PR and submodule update in E3SM.

@dengwirda, I have run all three wave drag schemes with the cleanup changes we discussed. Here are the M2 deep water RMSE values compared to the best errors from Kristin's...

I think I also now understand the reason our LGF coefficients are so large (3000 vs the 2.5ish used for adcirc). The lat/lon gradients calculated in the init step are...

Actually, we should just use the `bed_dz_dx` and `bed_dz_dy` values from the pixel file.

@jonbob, I still need to report back about the LGF coefficients @dengwirda was asking about. Sorry, I got sidetracked on this.

@dengwirda, I confirmed that with the LGF changes described above (e.g. https://github.com/MPAS-Dev/compass/pull/802/commits/ab0da3123721d45a8f4215539541ebb1cd044147), the model achieves a 3.36 cm deep M2 RMSE with a wave drag coefficient of 2.5. That wave...

@jonbob, this one is ready now when convenient.

@dengwirda - no problem, I'm glad we got it sorted out. Thank you for the SAL/HA changes in this PR. I appreciate you taking the time to review as well!