pymediainfo icon indicating copy to clipboard operation
pymediainfo copied to clipboard

Bundled wheels: update hashes automatically

Open getzze opened this issue 11 months ago • 4 comments

Follow-up to https://github.com/sbraz/pymediainfo/pull/141#issuecomment-2646822640

This PR adds a script to update the version of the bundled libmediainfo library and to update the checksums of the files to download from MediaInfo.

Instead of hard-coding the mediainfo version and hashes in the download_library.py script, this information is put in pyproject.toml. Then the new update_checksums.py scripts is used to update the values in the pyproject.toml config file.

A typical workflow to regenerate bundled wheels with the latest MediaInfo version, for all the platforms and architectures:

pdm run update_checksums
pdm run build_all

getzze avatar Feb 12 '25 21:02 getzze

Sorry for the big PR, it was not as simple to implement as I first thought :sweat_smile:

getzze avatar Feb 12 '25 21:02 getzze

If you've used it before, is GitHUB's CI faster than AppVeyor? AppVeyor's 1 job limit makes it reaaaaaaally long to run the whole CI :/ And I think you mentioned GH CI before :)

sbraz avatar Feb 12 '25 22:02 sbraz

Yes it's much faster... It also cancels jobs when a new commit is pushed in a PR, so you don't have to wait for outdated jobs to finish.

On 12 February 2025 22:07:06 GMT+00:00, Louis Sautier @.***> wrote:

If you've used it before, is GitHUB's CI faster than AppVeyor? AppVeyor's 1 job limit makes it reaaaaaaally long to run the whole CI :/ And I think you mentioned GH CI before :)

-- Reply to this email directly or view it on GitHub: https://github.com/sbraz/pymediainfo/pull/144#issuecomment-2654946367 You are receiving this because you authored the thread.

Message ID: @.***>

getzze avatar Feb 12 '25 23:02 getzze

The test that needs libcurl.dll is still failing on windows, I will revert the changes, it will simplify dowload_library code. I think it's better to just skip this test on Windows systems.

getzze avatar Feb 13 '25 21:02 getzze