sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

Admin with 'Root Admin (Full Admin Access)' permissions not able to delete bans

Open DNA-styx opened this issue 1 year ago • 2 comments

What are the steps to reproduce this issue?

  1. Log in with account that has 'Root Admin (Full Admin Access)' permissions
  2. Go to bans page
  3. Select one or more bans
  4. Click 'actions' drop down

What happens?

'Delete' option doesn't appear in drop down

What were you expecting to happen?

'Delete' option to appear in drop down

Any logs, error output, etc.?

Currently image

After below fix image

Looks to be fixed by changing line 812 of page.banslist.php

$theme->assign('can_delete', $userbank->HasAccess(ADMIN_OWNER) || HasAccess(ADMIN_DELETE_BAN));

Any other comments?

This issue appears to be in the comms block page as well.

What versions of software are you using?

Operating System: SourceBans++ Version: 1.8.0 | Git: 1411 PHP Version: MySQL Version: Link to your project: Link to a phpinfo() output:

DNA-styx avatar Sep 03 '24 18:09 DNA-styx

Could you verify your user permission ? I was unable to repro this issue, also this issue can't occure on comms list, the tickbox feature is not implanted in it yet.

Rushaway avatar Sep 14 '24 12:09 Rushaway

Thanks for checking. Yes, only applies to Bans page

My permissions image Set using image Bans page with variables echoed image Using this code image

DNA-styx avatar Sep 14 '24 17:09 DNA-styx