sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard
verified publisher icon sbpp

Add optional gametracker support

Open connorrichlen opened this issue 2 years ago • 9 comments

Description

-adds gametracker optional feature to display banner -uses updater to add mysql setting

Motivation and Context

  • for server maintainers that want to display gametracker status

How Has This Been Tested?

-tested on an existing sb install

Screenshots (if appropriate):

https://i.gyazo.com/16377ab56df7714fbc75993439199747.png

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING document.

connorrichlen avatar Sep 27 '23 16:09 connorrichlen

Nice job. 😉 You missing to add the settings in the features as a checkbox. Ex: https://github.com/sbpp/sourcebans-pp/blob/e3e8ff144b6dc1d5bb4d7c279eb5852a10d1faa8/web/themes/default/page_admin_settings_features.tpl#L47-#L54 And for the version bump. Idk if maintainer want to bump it.

Rushaway avatar Sep 27 '23 17:09 Rushaway

Maybe switch to 160px banner if server isn't empty ? What do you think? Acutal render with the banner. image

Rushaway avatar Sep 27 '23 17:09 Rushaway

Haha thank you :D I seemed to have forgotten to actually add the support

connorrichlen avatar Sep 27 '23 17:09 connorrichlen

Maybe switch to 160px banner if server isn't emptyimage

good call, check this out

connorrichlen avatar Sep 27 '23 17:09 connorrichlen

When you tick the box, settings are correctly saved ? Based on e5bfd77bba764d6d8c821ae939ac0480fb776520

Rushaway avatar Sep 27 '23 17:09 Rushaway

yes, but it requires a mysql entry, hence the new updater script

i did this a while ago on my own installation so i copied over what i remembered i did in the PR haha

connorrichlen avatar Sep 27 '23 17:09 connorrichlen

@crashzk You was able to make it run?

Rushaway avatar Nov 20 '23 19:11 Rushaway

@crashzk You was able to make it run?

No, I'm sorry... Since CS2 was released I closed the CSGO servers and focused on it, due to the limitations of the sourcebans it is currently "offline" so to speak.

crashzk avatar Nov 20 '23 19:11 crashzk

I still can't make it run correctly. (tickbox aren't saved)

https://github.com/sbpp/sourcebans-pp/pull/927/files#diff-e3bb73ab9b4faf337bcf13a28231466a64044b4cae744db0e3581e6c432b3133R5 Value should not be null, you can use 536 as id

Rushaway avatar Feb 06 '24 20:02 Rushaway