sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

Add comments parameter to SBPP_BanPlayer native

Open sneak-it opened this issue 6 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Nope, no current problem.

Describe the solution you'd like

It would be helpful to implement an extra parameter in SBPP_BanPlayer for the "Comments" section of a ban. A couple examples of usage:

This would work well in a scenario such as an automated Anti-Cheat ban, where the public facing reason is very broad, but the actual logged data is accessible by a logged-in admin, via the comments section.

Another example would be of an admin banning a player providing a reason, however also including an internal account/more details for other admins that should not be public.

Describe alternatives you've considered

N/A

Additional context

N/A

sneak-it avatar Jan 31 '19 19:01 sneak-it

So, I have been thinking about this feature request and I think it should move to its own native native bool SBPP_AddComment(int iBanID, ...);, since the comments are in a separate table and rely on the insertion ID of the ban.

On top of that, the inserted ID (ban id) isn't returned from the ban native, and there's also the possibility of the insertion failing and queued to be attempted later again .

rumblefrog avatar Oct 01 '19 03:10 rumblefrog

This would work well in a scenario such as an automated Anti-Cheat ban, where the public facing reason is very broad, but the actual logged data is accessible by a logged-in admin, via the comments section.

i would love to utilize this for my own anticheat and looked into writing the native myself, but it'd be too much of a pain as i'm not at all knowledgeable in that aspect of sm. @ rumble , please implement this

sapphonie avatar Jul 05 '20 11:07 sapphonie