sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

Published 20 hours ago • verified publisher icon sbpp

Migrate from ADODB to PDO

Open Groruk opened this issue 8 years ago • 8 comments

Groruk avatar Feb 06 '17 09:02 Groruk

This is nice idea. What will be used? PDO?

CrazyHackGUT avatar Feb 06 '17 11:02 CrazyHackGUT

#214 yes

Groruk avatar Feb 06 '17 11:02 Groruk

Nice! I'll maybe try switch from ADOdb to PDO and create pull request for this repo.

CrazyHackGUT avatar Feb 06 '17 11:02 CrazyHackGUT

I'm already working on it

Groruk avatar Feb 06 '17 12:02 Groruk

Oh, ok.

CrazyHackGUT avatar Feb 06 '17 13:02 CrazyHackGUT

Out of curiosity, how come this is no longer part of the (Initial) 1.6.0 release?

Hazbelll avatar Apr 21 '17 14:04 Hazbelll

Tbh I have done most of the updates from ADODB to PDO here, but I also encountered some strange behavior of PDO with SourceBans++ (these are mostly easy to fix, but I want to release 1.6.0 as fast as possible because of all the security fixes). That's why I postponed the migration to PDO for a later release.

Groruk avatar Apr 21 '17 16:04 Groruk

Ah, alright. Makes sense. Thanks for the clarification.

Hazbelll avatar Apr 21 '17 20:04 Hazbelll