sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

[BUG] Links on ban comments are converted automatically to "$1"

Open sys-arch opened this issue 11 months ago • 6 comments

What are the steps to reproduce this issue?

Steps to reproduce the behavior:

Login to Sourcebans
Go to Bans List
Click on any ban you have
Click on "Add comment" (if you have luck because button don't always work)
Add any external link to comment and publish it
See error

What happens?

When an admin bans a player, they add a comment with a link to the video or screenshots to prove the validity of the ban. However, when the comments are posted, the links are converted to a link that says "$1" and whose link is https://example.com/$1 where example.com is the URL of the Sourcebans installation.

What were you expecting to happen?

Should appear link as it

Any logs, error output, etc.?

No.

Any other comments?

I reported this to the theme repo i use and developer says is a problem of SB++ core.

https://github.com/DNA-styx/SBPP-Windmill-Dashboard/issues/66

What versions of software are you using?

Operating System: Linux SourceBans++ Version: SourceBans++ 1.8.1 | Git: 1434 PHP Version: 8.3 MySQL Version: MariaDB unknown version

sys-arch avatar Jan 13 '25 10:01 sys-arch

Hello @Rushaway @Hackmastr anything to say about this? This was put 3 months ago...

sys-arch avatar Mar 22 '25 22:03 sys-arch

Hello, sorry for the delay, it should be fix now. (PR in progress)

Rushaway avatar Apr 16 '25 10:04 Rushaway

Can be closed after https://github.com/sbpp/sourcebans-pp/pull/1046 get merged

Rushaway avatar May 19 '25 08:05 Rushaway

Hello @Rushaway When will you will merge this fix??

sys-arch avatar Jul 16 '25 11:07 sys-arch

I'm just a contributer @sys-arch , i'm not a maintener so can't push on this repo. @Hackmastr can do it

Rushaway avatar Jul 16 '25 12:07 Rushaway

I'm just a contributer @sys-arch , i'm not a maintener so can't push on this repo. @Hackmastr can do it

Sorry for the confusion and thanks for the clarification.

sys-arch avatar Jul 20 '25 13:07 sys-arch