Simone Bordet

Results 555 comments of Simone Bordet

Please also rebase on 12.0.x.

`NetworkTrafficListener` is very old and probably not appropriate anymore, as it only supports `Socket` so won't be usable now that we also support `DatagramSocket`.

`AsyncMiddleManServlet` is a proxy servlet dedicated to mutate content. If you don't need to mutate content, don't use it, and use instead `ProxyHandler` (recommended) or `AsyncProxyServlet`. As for `AsyncMiddleManServlet`, did...

It's not a bug, perhaps a missing feature. `AsyncMiddleManServlet` performs a `ServletOutputStream.write()` which may be buffered, and there is no explicit API in `AsyncMiddleManServlet` to allow applications to force the...

In the email thread you linked, @gregw suggested that flushes are asynchronous, so yes you have to call `isReady()`. This is because if you did an asynchronous write, and the...

I am referring to RST_STREAM. The term "graceful termination" is used when sending GOAWAY, so I would not confuse the two. If the client stops sending frames for a particular...

@iiliev2 let us know if you would like to contribute the improvement discussed above, otherwise we'll do it.

@iiliev2 no, we only accept contributions to the 12.0.x branch.

> I just noticed something suspicious. `AsyncMiddleManServlet.ProxyWriter#chunks = new ArrayDeque()`, which is not a threadsafe class, looks like is getting modified concurrently. Good catch. > Related to this, I still...