SFBAudioEngine icon indicating copy to clipboard operation
SFBAudioEngine copied to clipboard

Make `std::jthread` support conditional based on C++ `201911L`

Open sbooth opened this issue 1 month ago • 1 comments

This is a draft PR to address uncertain availability of std::jthread in Apple clang.

sbooth avatar Dec 01 '25 14:12 sbooth

@sbooth would love this ;)

farfromrefug avatar Dec 02 '25 08:12 farfromrefug

@sbooth so you didnt go that route? how are you going to fix the build?

farfromrefug avatar Dec 21 '25 22:12 farfromrefug

I don't think that there is anything wrong with the build that needs to be fixed in main. It works correctly with Xcode 26 which I consider the baseline configuration.

sbooth avatar Dec 22 '25 22:12 sbooth

@sbooth but it wont build on intel mac using xcode 16. It is just one version below :( Forcing people to use xcode 26 is pretty tough. Not even sure i can install xcode 26 on intel

farfromrefug avatar Dec 22 '25 23:12 farfromrefug

I'm sure whether Xcode 26 is a tough requirement could be debated either way, but Xcode 26 does work on Intel Macs. I have an older Intel model and I'm using Xcode 26 with no issues. The only restriction I know of is that the visionOS SDK requires an ARM processor.

sbooth avatar Dec 22 '25 23:12 sbooth

@sbooth still pretty sad to see you force people to use xcode 26. Never seen a library do that kind of "requirement". Will have to fork and manage it in my fork. Thanks for the work you ve done

farfromrefug avatar Dec 22 '25 23:12 farfromrefug

I'll reopen this PR for further consideration.

sbooth avatar Dec 23 '25 00:12 sbooth