Watcharr icon indicating copy to clipboard operation
Watcharr copied to clipboard

feat: added nav menu item close on click outside

Open antoniosarro opened this issue 1 year ago • 3 comments

Navbar menus now close when anywhere outside the menu is clicked.

Related to issue #813

antoniosarro avatar Feb 19 '25 10:02 antoniosarro

I made the changes and it seems to work as it should, I don't know if it is necessary to define the id used to exclude buttons as a const somewhere so that it is easier to modify it in case for each occurrence. I also made the other changes you listed

antoniosarro avatar Feb 20 '25 01:02 antoniosarro

Hi @antoniosarro, thanks for making them changes. Looks like I am seeing a new bug:

Clicking into the nav or body just below the nav still closes to popup, but for some reason clicking anywhere in the posters wrapper or on posters doesn't close the popup (eg: space around posters, poster rating/status button). Same on other pages too, just the top part of the page will close them, nothing in the actual body.

IRHM avatar Feb 21 '25 00:02 IRHM

Yes, I saw that it was a bug that I had missed because when I tested it the poster wrapper was not present. Now I checked and it doesn't give that problem anymore. I checked that repeatedly clicking on the icon, clicking within the open menu and clicking within the page works and they all seem to work as they should.

antoniosarro avatar Feb 21 '25 15:02 antoniosarro