rcsbsearch icon indicating copy to clipboard operation
rcsbsearch copied to clipboard

Published 20 hours ago • verified publisher icon sbliven

Update to use the v2 API as v1 has been fully discontinued

Open ncoish opened this issue 2 years ago • 6 comments

As of today (2022-07-13), the v1 version of the RCSB search API has been fully discontinued. This PR swaps the library to use the v2 version of the API, following the migration guide detailed here.

The PR also addresses a small number of typos and bugs which are not detailed in the migration guide, but which may be related to the API change.

ncoish avatar Jul 13 '22 22:07 ncoish

@ncoish Thanks for this PR! I'm just coming back from vacation but I'll try to review and merge this soon.

sbliven avatar Jul 25 '22 16:07 sbliven

Any update on this? Would be nice to have it merged.

shervinnia avatar Aug 12 '22 18:08 shervinnia

@ncoish Thanks for this PR! I'm just coming back from vacation but I'll try to review and merge this soon.

Hey @sbliven, have you had a chance to take a look at this yet?

ncoish avatar Aug 23 '22 14:08 ncoish

Heyy will this be merged soon..? The client is super useful, and would be great to have ti working (again)

uros-sipetic avatar Sep 06 '22 22:09 uros-sipetic

Yes, please update this. All downstream code CI stopped working because of it.

joelb123 avatar Oct 10 '22 16:10 joelb123

FYI: https://github.com/sbliven/rcsbsearch/issues/4#issuecomment-1721469353

piehld avatar Sep 15 '23 16:09 piehld