sag icon indicating copy to clipboard operation
sag copied to clipboard

Fix for PHP 7 compatibility

Open skeyby opened this issue 7 years ago • 4 comments

We recently updated our machines to PHP 7.1 and the code got stuck in the fgets because it was failing to understand that the transfer was chunked.

We did a side by side trace with PHP 5.6 and found this line to behave differently.

Now it's working ok.

skeyby avatar Oct 27 '17 13:10 skeyby

Hi, i had a similar issue on php7 and on the file: sagCurlHTTPAdaptater.php, fixed on line 124, by replacing $response->headers->$line[0] = ltrim($line[1]); by $response->headers->{$line[0]} = ltrim($line[1]);

kyoun8 avatar Dec 02 '17 13:12 kyoun8

@skeyby do you still maintain your own version?

boussou avatar Oct 04 '20 23:10 boussou

Yes

Inviato da iPhone

Il giorno 5 ott 2020, alle ore 01:12, Nadir Boussoukaia [email protected] ha scritto:

 @skeyby do you still maintain your own version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

skeyby avatar Oct 05 '20 00:10 skeyby

Ok, I forked your project, and indeed your change is mandatory on PHP 7.x. So I consider your repo as master - is more up to date.

boussou avatar Oct 05 '20 14:10 boussou