video_trimmer icon indicating copy to clipboard operation
video_trimmer copied to clipboard

Slidable implementation of the TrimEditor

Open lan2000 opened this issue 3 years ago • 6 comments

video_trimmer 0.5.1 android 10

TrimEditor's sliding selection time period is abnormal. No such problem in the previous version.

lan2000 avatar Jun 30 '21 08:06 lan2000

When the video thumbnail is loaded, the white selection box control cannot slide

https://user-images.githubusercontent.com/29618907/123928344-68cac700-d9c0-11eb-8251-3763a35269fd.mp4

lan2000 avatar Jun 30 '21 08:06 lan2000

@lan2000 have you set any maxVideoLength while using the TrimEditor widget?

Can you please share the code snippet of just the TrimEditor widget, so that I would get to know how you have declared it?

Also, please attach your Flutter doctor output.

sbis04 avatar Jul 01 '21 02:07 sbis04

flutter doctor [√] Flutter (Channel stable, 2.2.2, on Microsoft Windows [Version 10.0.19042.630], locale zh-CN) [√] Android toolchain - develop for Android devices (Android SDK version 30.0.3) [√] Chrome - develop for the web [√] Android Studio (version 4.0) [√] Connected device (4 available)

• No issues found!

The above problem occurs when I set viewerWidth beyond the screen width

TrimEditor(
                      trimmer: _trimmer,
                      viewerHeight: 50.0,
                      // viewerWidth: MediaQuery.of(context).size.width,
                      viewerWidth: 3000,
                      maxVideoLength: Duration(seconds: 5),
                      onChangeStart: (value) {
                        _startValue = value;
                      },
                      onChangeEnd: (value) {
                        _endValue = value;
                      },
                      onChangePlaybackState: (value) {
                        setState(() {
                          _isPlaying = value;
                        });
                      },
                    )

lan2000 avatar Jul 01 '21 04:07 lan2000

Another problem is that if the video duration is relatively long, the distance selected by TrimEditor becomes shorter and it is difficult to slide. The video just selected is about 4 minutes. The slider on the right side of TrimEditor can't slide.

https://user-images.githubusercontent.com/29618907/124064461-696a6880-da67-11eb-96fe-764296e5d9c9.mp4

lan2000 avatar Jul 01 '21 04:07 lan2000

The above problem occurs when I set viewerWidth beyond the screen width

Yes, if you set the viewerWidth to be greater than the screen width this would occur because currently the thumbnails are generated in a is scrollable ListView.

Another problem is that if the video duration is relatively long, the distance selected by TrimEditor becomes shorter and it is difficult to slide.

Yes, this is also an issue. I'll try to work on a fix for these soon.

A slidable implementation of the TrimEditor will be better for longer videos.

sbis04 avatar Jul 01 '21 08:07 sbis04

Any solutions for new version 1.0.0?

harsuu942 avatar Jan 20 '22 11:01 harsuu942