Replace redundant `x_shape`

Open manuelgloeckler opened this issue 1 year ago • 1 comments

Description

The new DensityEstimators will have a _condition_shape attribute, which is required to correctly handle batch shapes on x_o.

Currently, all posterior classes also have a _x_shape attribute which does contain the same information and is thus no longer required.

Mar 15 '24 15:03 manuelgloeckler

@manuelgloeckler has this been fixed by #1151 ?

Jun 18 '24 07:06 janfb

This is actually solved: in the posterior docstrings we say it's deprecated and if it is passed by a user we issue a deprecation warning. We can leave as it is for now and remove the argument from all the posterior classes in the next release.

Aug 30 '24 07:08 janfb

Great! We should also check that the trainers and potentials also do no longer have x_shape

Aug 30 '24 07:08 michaeldeistler