sbi Added show_progress_bars option to ImportanceSamplingPosterior

Fixed issue #933.

Feb 14 '24 01:02 kevnster

Hi @kevnster! Thanks a lot for creating this PR! Could you run black formatting? Tests are failing right now because of it.

Feb 14 '24 08:02 michaeldeistler

TODO:

[ ] adapt the tests: add show_progress_bars=False to the call to sample(...) here: https://github.com/sbi-dev/sbi/blob/3b1f34e3a5755f097652d8e54767881ad783d630/tests/linearGaussian_snle_test.py#L508 and here https://github.com/sbi-dev/sbi/blob/3b1f34e3a5755f097652d8e54767881ad783d630/tests/linearGaussian_snre_test.py#L421
[ ] run these two tests locally (they are not part of CI because they are marked as slow) by running: pytest tests/linearGaussian_snle_test.py::test_api_snl_sampling_methods (and the same for the snre test) and make sure they pass.
[ ] as @michaeldeistler said: please run black . and isort . locally and push again.

Feb 14 '24 08:02 janfb

@kevnster are you still interested in working on this? If not (no problem) I will close this PR and fix it in a different one.

Best, Jan

Feb 22 '24 10:02 janfb

Yes, I am still interested. I will complete it by tonight! Sorry for the delays.

Feb 22 '24 19:02 kevnster

Great, thank you!

Feb 23 '24 10:02 janfb

Hi @kevnster I quick reminder for fixing this PR. We need to get this in by Friday. No problem if you cannot make it, just let us know.

Mar 12 '24 15:03 janfb

closed due to inactivity. feel free to re-open.

Apr 02 '24 11:04 janfb