sbi icon indicating copy to clipboard operation
sbi copied to clipboard

Fix pickle issues in MCMC posterior + test

Open manuelgloeckler opened this issue 1 year ago • 1 comments

What does this implement/fix? Explain your changes

This PR address the issue of the MCMCPosterior not being pickable after running sample.

Does this close any currently open issues?

Fixes #1278

Any other comments?

Extended the save and load tests to be performed after calling sample and log_prob once.

manuelgloeckler avatar Oct 07 '24 11:10 manuelgloeckler

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.43%. Comparing base (428fc93) to head (56c6a5e). Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1291       +/-   ##
===========================================
- Coverage   89.30%   78.43%   -10.87%     
===========================================
  Files         119      119               
  Lines        8721     8732       +11     
===========================================
- Hits         7788     6849      -939     
- Misses        933     1883      +950     
Flag Coverage Δ
unittests 78.43% <100.00%> (-10.87%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/posteriors/mcmc_posterior.py 86.14% <100.00%> (-0.55%) :arrow_down:

... and 31 files with indirect coverage changes

codecov[bot] avatar Oct 07 '24 12:10 codecov[bot]