sbi icon indicating copy to clipboard operation
sbi copied to clipboard

Add `CategoricalMADE`

Open jnsbck opened this issue 5 months ago • 3 comments

What does this implement/fix? Explain your changes

This implements a CategoricalMADE to generelize MNLE to multiple discrete dimensions addressing #1112. Essentially adapts nflows's MixtureofGaussiansMADE to autoregressively model categorical distributions.

Does this close any currently open issues?

Fixes #1112

Comments

I have already discussed this with @michaeldeistler.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read and understood the contribution guidelines
  • [x] I agree with re-licensing my contribution from AGPLv3 to Apache-2.0.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have reported how long the new tests run and potentially marked them with pytest.mark.slow.
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I performed linting and formatting as described in the contribution guidelines
  • [ ] I rebased on main (or there are no conflicts with main)
  • [ ] For reviewer: The continuous deployment (CD) workflow are passing.

jnsbck avatar Sep 05 '24 10:09 jnsbck