sbi icon indicating copy to clipboard operation
sbi copied to clipboard

Slow L-C2ST test fails locally

Open manuelgloeckler opened this issue 1 year ago • 1 comments

Describe the bug L-C2ST (slow) tests fail locally.

FAILED tests/lc2st_test.py::test_lc2st_true_positiv_rate[LC2ST_NF] - AssertionError: LC2ST p-values too small, test should be accepted         at least 95.0% of the time, but was accepted         only 45.0% of the time.

To Reproduce

pytest tests/lc2st_test.py::test_lc2st_true_positiv_rate[LC2ST_NF]

On the current main, Python 3.11.7. (might dependents on python version)

This might be due to insufficient seeding or to strict tolerance for test.

manuelgloeckler avatar Jun 18 '24 15:06 manuelgloeckler

@JuliaLinhart can you have a look at this please?

janfb avatar Jun 25 '24 13:06 janfb

reason: for this test, the density estimator has to be off, but it was using too many simulations and became too good.

fixed with #1209

janfb avatar Aug 06 '24 11:08 janfb