sbi icon indicating copy to clipboard operation
sbi copied to clipboard

Add MDNDensityEstimator

Open jnsbck opened this issue 11 months ago • 5 comments

…oned, and corrected for proposals, bot in SNPE-A and SNPE-C

What does this implement/fix? Explain your changes

This PR attempts to consolidate the functionalities of the various mixture density objects used throughout the toolbox, for details see #989 into one MixtureDensityEstimator. I will try to do this by implementing a MoG object on which conditioning, marginalization and proposal correction can be done if necessary, but it behaves like a Flow otherwise.

Does this close any currently open issues?

Fixes #989

Any relevant code examples, logs, error output, etc?

...

Any other comments?

PR is a WIP and subject to change. dev.ipynb already contains a working sketch of the implemetation though.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have read and understood the contribution guidelines
  • [ ] I agree with re-licensing my contribution from AGPLv3 to Apache-2.0.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have reported how long the new tests run and potentially marked them with pytest.mark.slow.
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I performed linting and formatting as described in the contribution guidelines
  • [ ] I rebased on main (or there are no conflicts with main)

jnsbck avatar Mar 19 '24 19:03 jnsbck

Hi @jnsbck, can you please add a description of this PR? I am sure the PR makes total sense, I just could see directly what it is planning to do.

another comment: MixedDensityEstimator is already used in the context of mixed data (for MNLE). Maybe you can call it MixtureDensityEstimator?

Thanks 🙏

janfb avatar Apr 09 '24 06:04 janfb

Yea of course. Was planning to continue working on it. Left the desc blank since its in draft state. Yes, can rename it to MixtureDensityEstimator. :)

EDIT: updated the desc. working on this is on my Todo :)

jnsbck avatar Apr 09 '24 14:04 jnsbck

Ping @jnsbck :) What is the status here, is there anything we can help with?

janfb avatar Apr 23 '24 07:04 janfb

Have too much of other stuff on my plate currently, so I have not been actively working on this. Still on my todo though. I hope I will get around to finishing this at some point. Feel free to take the template and add to it though if you need some of the functionality urgently.

Will let you know when I start working on it again and where I need help :)

jnsbck avatar Apr 23 '24 09:04 jnsbck

OK, thank you for the update @jnsbck 🙏

janfb avatar Apr 24 '24 11:04 janfb

I am closing this PR for now. Feel free to re-open of re-use in a future PR.

janfb avatar Sep 09 '24 12:09 janfb