Shreyas Bethur
Shreyas Bethur
### Description of issue In niscope's `fetch` and `read` methods, `num_samples` = `None` means fetch/read all available samples. This behavior is not captured in method documentation.
- [x] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md). ~- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.~ ~- [ ] I've added tests applicable for this pull request~ ### What does this...
- [x] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md). ~- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.~ ~- [ ] I've added tests applicable for this pull request~ ### What does this...
### Description of issue For attributes that have `attribute_class` key in metadata (e.g. `AttributeViReal64TimeDeltaSeconds`) and for method parameters that have `python_api_converter_name` key in metadata (e.g. `convert_timedelta_to_seconds_real64`), there is an additional...
### Description of issue In nidcpower 1.0, Advanced Sequencing was not part of the public API (https://github.com/ni/nimi-python/issues/504). It could still be done via private API. Hence, the example for it...
### Description of issue `AttributeViInt32TimeDeltaMilliseconds` attribute class is not used anywhere other than in nifake; yet it is code-generated into the attribute class of all modules. We should get rid...
### Description of issue Unit tests run against source files of the module in `generated` folder. System tests are run by building a `sdist`, which doesn't install the dependencies. This...
Implementation of __repr__ for custom types should be updated to use `__module__` and `__qualname__`
### Description of issue Best practice for implementing `__repr__` for custom types is to use `__module__` and `__qualname__`. By including `__module__` in `__repr__`, `eval(repr(CustomType()))` can be called by importing nimi-python...
### Description of issue Best practice for implementing `__repr__` for custom types is to use `__module__` and `__qualname__`. By including `__module__` in `__repr__`, `eval(repr(CustomType()))` can be called by importing nifake...
### Description of issue In `__init__.py`, we [re-export the types](https://github.com/ni/nimi-python/blob/896c33b9f8e3d21b2224d31da6acc58d26def8e5/generated/niscope/niscope/__init__.py#L8) contained in the module like: ``` from niscope.errors import DriverWarning # noqa: F401 from niscope.errors import Error # noqa: F401...