Sebastian Bernauer

Results 33 comments of Sebastian Bernauer

Yep, I have noticed the failing tests as well. I already have an idea on how to solve this (with no performance penalty), but I did not continue any further...

Hi, just a small nitpick: > Stable release - ETA Jan 30 2024 should be > Stable release - ETA Jan 30 2025 This confused me a bit, as I...

@nightkr do you plan to merge this or add the WIP functionality of secret-op beforehand, so that the kafka broker certificates will include the listener addresses? It'd be awesome if...

@nightkr given you opened https://github.com/stackabletech/operator-rs/pull/858 (reviewed it), I would be very in favor of putting the listenerVolume scope on the secret-op mount, so that we have valid certificates. This would...

Agreed. I'm a bit torn between "we should label everything" and "I don't want everything to show in stacklet list". I'm happy to merge as-is, but than please add a...

Just for the record: I think there is value in having the metrics endpoint for every individual broker, but as most customers will probably use Prometheus ServiceMonitor this is rather...

Somewhat related: Is it intentional that the `simple-kafka-broker-default-bootstrap` Listener contains the `ingressAddress` three times in the status? Do we want to de-duplicate that list in listener-op? ```yaml apiVersion: listeners.stackable.tech/v1alpha1 kind:...

> That smells like a minor bug that I would suggest filing against list-op. I was not sure if this was a bug. Created https://github.com/stackabletech/listener-operator/issues/229

Thanks, LGTM! Hopefully last remaining question: We do we have a bootstrap service per rolegroup? Don't all bootstrap services return all brokers (from all rolegroups) regardless? Why aren't we using...

Should be a pretty easy fix, on the other hand I would also like to implement usage of listener-op in kafka, which might make more sense