Sylvain Bellemare
Sylvain Bellemare
From @r-marques in https://github.com/bigchaindb/cryptoconditions/pull/67#issuecomment-310113354: > We should cleanup conftest.py. There are a lot of constants and fixtures that are no longer being used.
From @r-marques in https://github.com/bigchaindb/cryptoconditions/pull/67#issuecomment-310113354: > I don't think we should expose methods like to/from asn1_dict/asn1_json since they are on the spec and are specific to different asn1 implementations. We should...
Duplicate tests under `tests/test_generated_valid_spec.py` The gist of the thing is that the test suite is parametrized, and a different version of it is not, to facilitate troubleshooting. One approach could...
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123244753
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123246766
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123242994
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123230856
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123226706
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123222127
see https://github.com/bigchaindb/cryptoconditions/pull/67#discussion_r123221791