Neoformat not working with php-cs-fixer : error in formatters/php.vim ?

[hutou]

Hi, Whenever I tried to save a valid php file, the vim buffer was cleared and an empty file was written (I use uptodate Neoformat and php-cs-fixer).

After browsing Neoformat code, I found that adding the line : \ 'replace': 1 in the function neoformat#formatters#php#phpcsfixer() solved the problem.

Is this the correct solution ?

[cdayjr]

I ran into this as well (despite having it work fine for me previously (?) not sure what exactly happened that changed the behavior) and adding the replace config setting to it did fix it, so I made a PR and it's merged now https://github.com/sbdchd/neoformat/pull/306 - missed this issue.

I'm not sure if it's the correct solution overall (?); would love to know why it's happening. I did some debugging via the neoformat logs and the correct changes were showing up in the tmp file that gets generated, regardless of the setting.