Steve Dignam

Should `await asyncpg.create_pool()` return `Pool` instead of `None | Pool`

6

Thank you for the library! After setting this up I found that my connection pool logic is being flagged essentially I have: ```python connection_pool: asyncpg.Pool[asyncpg.Record] def on_startup() -> None: global...

Currently `get_connection` returns Any but can it return a Protocol or something? I feel like we could do something with the import literals like: ```python get_connection(backend="django.core.mail.backends.smtp.EmailBackend") ```

Improve the types for `.data` and `.validated_data` of the Serializers

1

```python class FooListSerializer(serializers.ListSerializer): ... reveal_type(FooListSerializer(data).data) # list[Any] ``` ```python class FooListSerializer(serializers.Serializer): ... reveal_type(FooListSerializer(data, many=True).data) # list[Any] reveal_type(FooListSerializer(data).data) # dict[str, Any] ``` need to investigate this more, what happens when passing...

add(dep): rest_framework as dev dependency

1

This makes it a little easier to dig through the code for proper types.

Specifically ```python def get_search_fields(self, view: APIView, request: Request) -> Any: ... # and def must_call_distinct(self, queryset: QuerySet[Any], search_fields: Any) -> bool: ... ``` Instead can be: ```python def get_search_fields(self, view:...

Currently we have `Serializer.errors` typed as `Any`, but I think we can use the `ReturnDict` type instead https://github.com/encode/django-rest-framework/blob/98e56e0327596db352b35fa3b3dc8355dc9bd030/rest_framework/serializers.py#L551-L559 can also update `BaseSerializer` and `Field` while we are at it

- added matching for type signatures that end with ticks e.g. b' :: a -> a - fixes #92

 Reproduce: 1. open a file 2. delete file 3. use open PR command 4. error!

Add Highlighting for TODO in comments

2

In syntax highlighting for some other [filetypes](https://github.com/fatih/vim-go/blob/master/syntax/go.vim#L132) [and](https://github.com/neovim/neovim/blob/536c0ba27e79929eb30850d8e11f2ed026930ab3/runtime/syntax/python.vim#L95) [languages](https://github.com/pangloss/vim-javascript/blob/master/syntax/javascript.vim#L48), there is specific highlighting for TODOs in comments. I think that would be nice for markdown as well. Such that `TODO:`...

Before, when pressing in a buffer that has &modified set to 0, repeat would produce an error: Error detected while processing function repeat#wrap: line 2: E21: Cannot make changes, 'modifiable'...