django-types icon indicating copy to clipboard operation
django-types copied to clipboard

Missing fallback_keys parameter for Signer.__init__ (Django 4.1)

Open nuschk opened this issue 2 years ago • 2 comments

The fallback_keys parameter to Signer.__init__ is missing. The complete signature should read as follows:

class Signer:
    def __init__(
        self,
        key: Optional[Union[bytes, str]] = ...,
        sep: str = ...,
        salt: Optional[str] = ...,
        algorithm: str = ...,
        fallback_keys: Optional[List[str]] = ...,
    ) -> None: ...

This is new in Django 4.1, which is, I hope, in scope?

Thanks!

nuschk avatar Oct 24 '22 08:10 nuschk

Thank you for the report!

yeah this project aims to track the latest version of django, but tends to get out of sync

sbdchd avatar Oct 24 '22 18:10 sbdchd

Understandable, that's I guess the nature of these kinds of things. Would it help for me to do a PR?

nuschk avatar Oct 25 '22 08:10 nuschk