Sam Clegg

Results 154 issues of Sam Clegg

There was a missing cast here that only showed up in i686-debug. See #2367.

Followup to #6206 See https://en.cppreference.com/w/cpp/language/string_literal

Its really hard to see the wood for the tree. For example these strings seem to appear hundreds of times in the output: ``` warning: no output file specified, not...

https://app.circleci.com/pipelines/github/emscripten-core/emsdk/2084/workflows/2e280ca8-1c22-435f-b602-58142371adba/jobs/12495 Some kind of issue with std::variant: ``` [ 95%] Building CXX object src/tools/CMakeFiles/wasm-opt.dir/wasm-opt.cpp.o In file included from /root/project/binaryen/main/src/tools/wasm-fuzz-lattices.cpp:21:0: /usr/include/c++/7/variant: In instantiation of 'constexpr const size_t std::variant_size_v': /usr/include/c++/7/variant:702:10: required from...

I'm currently landing a new test `test_atomic_wait64_notify` which is failing under wasm2js: ``` test_atomic_wait64_notify (test_core.wasm2js1.test_atomic_wait64_notify) ... Clearing existing test directory wasm2js: /usr/local/google/home/sbc/dev/wasm/binaryen/src/passes/I64ToI32Lowering.cpp:423: void wasm::I64ToI32Lowering::visitStore(wasm::Store *): Assertion `!curr->isAtomic && "atomic store...

I notices a strange failure on HEAD with a test that I guess we don't run anywhere: `./test/runner core2ss.test_pthread_dylink_tls` . The problem is with `-sSTACK_OVERFLOW_CHECK` which runs that StackCheck check...

In WASI we are discussing adding optional imports (also known as weak imports in the ELF spec) on top of the existing import system: https://github.com/WebAssembly/WASI/issues/36. For a more integrated solution...

imports/exports

BinaryEncoding.md currently says `The name section may appear only once, and only after the Data section.` The spec currently says: `The name section should appear only once in a module,...

binary format

This means that `make install` then only installs things that are meant to be part of the public facing toolchain. See https://llvm.org/docs/BuildingADistribution.html#difference-between-install-and-install-distribution The list binaries that get installed now differ...

When targeting wasm64 today llvm currently truncates the i64 pointer operand to call_indirect since call_indirect currently requires a i32. Should we add support for an i64 operand to call_indirect as...