Sam Clegg

Results 1781 comments of Sam Clegg

> It is a nice idea to try to use an exe instead of a bat launcher, though there is a complexity involved, namely Windows SmartScreen. It will prevent launching...

I'm prepared to abandon this change if it turns out there are no perf benefits of bug fixes.

Also this issue: ``` :: Work around Windows bug https://github.com/microsoft/terminal/issues/15212 : If this :: script is invoked via enclosing the invocation in quotes via PATH lookup, then %~f0 and ::...

> When I manually download the same file that I had compiled, I don't get a SmartScreen block. But when I download that file from another PC, it does indeed...

> > Presumably the same thing happen if you run `clang.exe` or `wasm-opt.exe`? > > Curiously it doesn't. Like I mentioned before, Unity has been shipping unsigned clang.exe and wasm-opt.exe...

Are you able to identify the specific issue with the powershell script? Perhaps @RReverser has some idea since he added this ps1 scripts back in #20416

Maybe another reason to drop the launcher scripts completely. See #24858.

(`-sSINGLE_FILE_BINARY_ENCODE` is enabled by default but yes it will help with all users of `-sSINGLE_FILE`)

@BilelGho, do you have time to continue this work? We have had a request that emscripten supports custom page sizes which in turn requires this PR to land: https://github.com/emscripten-core/emscripten/discussions/25885

For emscripten and the web (at least for now) we always a JS file to start the worker, and that JS file then loads the wasm file. However, because we...